This repository has been archived by the owner on Sep 26, 2019. It is now read-only.
[PAN-2852] privacy group id consistent #1667
Merged
+56
−55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iikirilov
force-pushed
the
pan-2852-privacy-group-id-consistent
branch
3 times, most recently
from
a74626c to
5d61d1c
Compare
shemnon
reviewed
Jul 12, 2019
| @@ -32,7 +32,7 @@ | |||
| import org.junit.Before; | |||
| import org.junit.Test; | |||
|
|
|||
| public class PrivateTxEnclaveErrorAcceptanceTest extends PrivacyAcceptanceTestBase { | |||
| public class EnclaveErrorAcceptanceTest extends PrivacyAcceptanceTestBase { | |||
There was a problem hiding this comment.
Did this file get renamed? It's unclear from the Github commit.
There was a problem hiding this comment.
Yes, the file was renamed. It should be PrivateTransactionEnclaveErrorAcceptanceTest but that is a mouthful so I have gone with EnclaveErrorAcceptanceTest which describes the test well
...a/tech/pegasys/pantheon/ethereum/mainnet/precompiles/privacy/PrivacyPrecompiledContract.java
Outdated
Show resolved
Hide resolved
...a/tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/privacy/EeaDeletePrivacyGroup.java
Outdated
Show resolved
Hide resolved
.../tech/pegasys/pantheon/ethereum/jsonrpc/internal/methods/privacy/EeaGetTransactionCount.java
Outdated
Show resolved
Hide resolved
This reverts commit bb246c4
iikirilov
force-pushed
the
pan-2852-privacy-group-id-consistent
branch
from
a9d2a50 to
c5a01bf
Compare
lucassaldanha
approved these changes
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Handle base64 <-> BytesValue conversion uniformly throughout Pantheon
As a side effect also fixes the private transaction gas required to 23992 as specified in PAN-2795
Fixed Issue(s)
PAN-2852